Skip to content

Fix typo in migration that removes the non-sso type#3715

Merged
jkachel merged 2 commits into
mainfrom
jkachel/fix-sso-migration
Jun 30, 2026
Merged

Fix typo in migration that removes the non-sso type#3715
jkachel merged 2 commits into
mainfrom
jkachel/fix-sso-migration

Conversation

@jkachel

@jkachel jkachel commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

What are the relevant tickets?

n/a

Description (What does it do?)

Noticed after testing #3714 that the non-sso contracts on RC weren't changed. The migration uses nonsso, which is incorrect; this fixes the migration.

How can this be tested?

This ended up being a bit more involved.

Before checking out this branch or updating, fake revert back to 0024: migrate b2b 0024 --fake.

Then, add back the integration_type field to the database. Fortunately this was a simple field, so the SQL to do that is also pretty simple:

alter table b2b_contractpage add integration_type varchar(255);

This can be run in a dbshell. This does make the field slightly differently than it was originally - it should be nullable at this point, which is fine.

Now, update this branch and run the migration forwards. It should work, and you should be able to reverse it too. There is new intermediary migration that makes integration_type nullable, so we can put the field back and backfill it if we do need to reverse out this migration again.

@github-actions

Copy link
Copy Markdown

OpenAPI Changes

Show/hide ## Changes for v0.yaml:
## Changes for v0.yaml:
No changes detected

## Changes for v1.yaml:
No changes detected

## Changes for v2.yaml:
No changes detected

Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

@dsubak dsubak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straightforward correction of a string constant, so happy to approve it on that basis.

I will note that I have not been able to test this against the noted instructions atm (see this thread for details) but that is only an issue for reverts.

… _then_ remove it, so we can backfill it if 0026 needs to roll back
@jkachel jkachel merged commit 925c8ea into main Jun 30, 2026
9 checks passed
@jkachel jkachel deleted the jkachel/fix-sso-migration branch June 30, 2026 15:21
@odlbot odlbot mentioned this pull request Jun 30, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants