Cowns: Fix Cown switch to be owned by GC#67
Merged
xFrednet merged 2 commits intomjp41:regions-mainfrom Feb 17, 2026
Merged
Conversation
xFrednet
reviewed
Feb 17, 2026
| @@ -678,7 +678,7 @@ int _PyCown_SwitchFromIpToGc(_PyCownObject *self, Py_region_t *contained_region) | |||
| return 1; | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| return 1; | |
| *contained_region = NULL_REGION; | |
| return 1; |
|
|
||
| if (_Py_atomic_compare_exchange_uint64(&self->owning_ip, &ipid, GC_IPID)) { | ||
| if (!_Py_atomic_compare_exchange_uint64(&self->owning_ip, &ipid, GC_IPID)) { | ||
| return -1; |
Collaborator
There was a problem hiding this comment.
Suggested change
| return -1; | |
| *contained_region = NULL_REGION; | |
| return -1; |
kulisak12
force-pushed
the
cowns-gc-fix
branch
from
1db8bf3 to
3a4b049
Compare
kulisak12
force-pushed
the
cowns-gc-fix
branch
from
3a4b049 to
f000cfc
Compare
xFrednet
changed the title
xFrednet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.