Open
Conversation
1. Remove redifiende flags 2. Comment out a debugging line 3. Pipe in a max global steps with a flag
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
aahladc
force-pushed
the
minor_fixes
branch
9 times, most recently
from
cff2767 to
97e9975
Compare
priyakasimbeg
requested changes
Mar 19, 2026
Contributor
priyakasimbeg
left a comment
priyakasimbeg
left a comment
There was a problem hiding this comment.
Could you update the description of the PR? It currently still says 'do not merge'.
Left some comments
- I don't think should to check in any json file outputs from the make_job_config.py
- the sbatch scripts should all be under utils/slurm
- I'm a bit confused why we need flags for all the config options in the run_jobs sbatch script. The nice thing about having the config is that we have a complete and reproducible record of the options we passed in.
| @@ -0,0 +1,87 @@ | |||
| #!/bin/bash | |||
Contributor
There was a problem hiding this comment.
Can you move this file into utils/slurm
| @@ -0,0 +1,299 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
I don't think we want to commit this file to the repository. Can you remove it from this branch?
| yes | gcloud auth configure-docker "$REPO" | ||
| docker pull "$IMAGE" | ||
|
|
||
| # Set variables from config file if not already set by flags |
Contributor
There was a problem hiding this comment.
So this script will now take flags for all of the config fields, that will override the config fields. Why do we need this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge.
This is for testing purposes only.
Scoring changes.