session: encode shared key metadata - #6989
Open
crazy-max wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
area/dockerfile
area/testing
area/frontend
area/session
labels
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-session-sharedkey-header-encoding
branch
from
July 27, 2026 09:46
bfdc3c2 to
729c6a3
Compare
crazy-max
marked this pull request as ready for review
July 27, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes docker/compose#13965
closes docker/buildx#3972
This fixes session setup when the shared key contains non-ASCII characters by encoding the value before it's sent through gRPC metadata and decoding it when the session manager receives it.
The session package now marks encoded shared-key metadata with a another header and preserves the original shared key after decoding.