not only filter out optional strings but also notted strings#1975
Open
DarioViva42 wants to merge 1 commit intomock-server:masterfrom
Open
not only filter out optional strings but also notted strings#1975DarioViva42 wants to merge 1 commit intomock-server:masterfrom
DarioViva42 wants to merge 1 commit intomock-server:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1974
Some small additions to also consider.
Maybe add some tests that check if now mixing different type of strings (nottable & optional & ‘normal’) works correctly.
Also what I find kind of strange is that here https://github.com/mock-server/mockserver/blob/master/mockserver-core/src/main/java/org/mockserver/collections/ImmutableEntry.java#L36-L42 isOptional only checks that key is optional. But isNotted not only checks the key but also that the value is not notted. Why the difference?