Drop deprecated streamablehttp_client
#1836
Open
+31
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Jan 6, 2026
Comment on lines
-56
to
-61
| CONTENT_TYPE = "content-type" | ||
| ACCEPT = "accept" | ||
|
|
||
|
|
||
| JSON = "application/json" | ||
| SSE = "text/event-stream" |
maxisbey
approved these changes
Jan 8, 2026
Contributor
maxisbey
left a comment
maxisbey
left a comment
There was a problem hiding this comment.
one comment as questino, feel free to dismiss
| providing support for HTTP POST requests with optional SSE streaming responses | ||
| and session management. | ||
| """ | ||
| from __future__ import annotations as _annotations |
maxisbey
requested changes
Jan 8, 2026
Contributor
maxisbey
left a comment
maxisbey
left a comment
There was a problem hiding this comment.
idk how to undo an approval. doing this quickly to remove it
Contributor
|
Just before merging, wanting to hear your thoughts on removing this so soon? I guess for v2 we don't want any already deprecated things bought over, is that your thinking? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.