Skip to content

Conversation

@Vaiz
Copy link

@Vaiz Vaiz commented Dec 19, 2025

Motivation and Context

This is a pretty simple change that fixes feature gates in a couple of places. It allows to use rmcp crate in server mode without enabling macros and base64 features reducing the dependency tree for applications that don't use those capabilities.

How Has This Been Tested?

I verified that it actually compiles now
cargo build -p rmcp --no-default-features --features server

Breaking Changes

There are no breaking changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@github-actions github-actions bot added T-dependencies Dependencies related changes T-config Configuration file changes T-core Core library changes T-model Model/data structure changes labels Dec 19, 2025
@alexhancock alexhancock self-requested a review January 14, 2026 16:58
@alexhancock
Copy link
Collaborator

@Vaiz LGTM. If you can adjust the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/ we can merge

I am also going to add a pre-commit hook for this.

@Vaiz
Copy link
Author

Vaiz commented Jan 14, 2026

@Vaiz LGTM. If you can adjust the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/ we can merge

I am also going to add a pre-commit hook for this.

@alexhancock , thanks for looking into that.
I've adjusted commit message, should be fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-config Configuration file changes T-core Core library changes T-dependencies Dependencies related changes T-model Model/data structure changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants