Optimize registry #441
Merged
Optimize registry #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @hiyuchang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the module registration system, moving from a decorator-based approach to a centralized, explicit mapping within Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and beneficial refactoring of the registry system, moving from a decorator-based approach to a centralized mapping scheme. This greatly improves maintainability and helps prevent circular import issues. The addition of comprehensive registry tests is also a valuable contribution. I've found one critical issue related to a circular import in the trinity/buffer/storage module, which I've detailed in the comments. Once that is addressed, this PR will be in great shape.
Collaborator
|
/unittest-all |
Summary
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-all |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and beneficial refactoring of the module registration system. It moves from a decorator-based approach to a centralized mapping within __init__.py files for each registry. This improves code organization, reduces import side-effects, and makes the registration process more explicit and easier to track. The changes are consistently applied across the entire codebase, including the core library, examples, and documentation. A comprehensive new test suite for the registry functionality has also been added, which is excellent. I've found a couple of minor typos in the documentation and test files, which I've commented on. Overall, this is a high-quality pull request that improves the maintainability of the framework.
Collaborator
Author
|
/unittest-all |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
pan-x-c
reviewed
Dec 18, 2025
pan-x-c
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@WORKFLOWS.register("math_boxed_workflow"), use the mapping scheme instead. Fix theimportaccordinglyChecklist
Please check the following items before code is ready to be reviewed.