Skip to content

Conversation

@hiyuchang
Copy link
Collaborator

Description

As the title says.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hiyuchang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the overall quality and readability of the codebase by addressing a series of typographical errors. The changes span across various files, including benchmark configurations, example agents, test files, reward functions, and workflow definitions. The primary goal is to ensure consistency and accuracy in comments, system prompts, and documentation strings, thereby improving clarity for developers and users alike.

Highlights

  • Typo Fixes in Benchmarking: Corrected 'seperately' to 'separately' in benchmark/bench.py and 'thinks' to 'think' in a system prompt within benchmark/config/guru_math-template.yaml.
  • Typo Fixes in Examples: Addressed multiple typos in example files, including changing 'interation' to 'iteration' in examples/agentscope_frozenlake/agent.py and examples/agentscope_frozenlake/utils.py, and correcting 'test-based environments' to 'text-based environment' and 'DONOT' to 'DO NOT' in examples/grpo_alfworld/README.md. Also, 'thinks' was corrected to 'think' in examples/mix_chord/get_openr1_data.py.
  • Typo Fixes in Tests: Corrected 'interation' to 'iteration' in tests/common/vllm_test.py.
  • Typo Fixes in Trinity Rewards: Fixed 'excepted_len' to 'expected_len' in trinity/common/rewards/dapo_reward.py and 'contaims' to 'contains' in trinity/common/rewards/naive_dapo_score.py.
  • Typo Fixes in Trinity Workflows: Numerous corrections were made across workflow definitions, including 'sparybottle' to 'spraybottle' and 'test-based environments' to 'text-based environment' in trinity/common/workflows/envs/alfworld/alfworld_workflow.py. In trinity/common/workflows/envs/sciworld/sciworld_workflow.py, 'you job' became 'your job', 'test-based environments' became 'text-based environment', and 'DONOT' became 'DO NOT'. Similar corrections for 'DONOT', 'Instruct', 'text-baed', 'find follow', and 'perfrom' were applied in trinity/common/workflows/envs/webshop/webshop_workflow.py. Additionally, 'thinks' was corrected to 'think' in trinity/common/workflows/math_ruler_workflow.py and trinity/common/workflows/math_trainable_ruler_workflow.py.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a number of typos across various files. The changes are correct. I've added a few suggestions to further improve the code and documentation in the areas that were modified. This includes addressing a variable shadowing issue, correcting a potentially confusing instruction in a prompt, and ensuring consistency between similar prompts.

Copy link
Collaborator

@garyzhang99 garyzhang99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyuchang hiyuchang merged commit 4150cc8 into modelscope:main Dec 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants