improve ray stat

[binary-husky]

Description

fix ray stat detection

[gemini-code-assist]

Summary of Changes

Hello @binary-husky, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the detection of a running Ray cluster might fail due to the 'ray' executable not being found in the expected location. The changes introduce a more robust mechanism to locate the 'ray' command, ensuring that the is_running utility function operates correctly across various environment configurations.

Highlights

• Improved Ray Status Detection: The method for checking if a Ray cluster is running has been enhanced to more reliably locate the 'ray' executable. It now first attempts to find 'ray' within the current Python environment's directory before falling back to the system's PATH.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the detection of the ray executable by checking the Python executable's directory before falling back to the system PATH. This is a good enhancement for isolated environments. However, the implementation continues to use subprocess.run with shell=True, which poses a security risk. My review provides a suggestion to mitigate this by passing the command as a list of arguments, which is a safer approach. This also includes a minor stylistic improvement for better code readability.

[pan-x-c]

/unittest-module-cli

[github-actions]

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
5	5	0	0	0	0	1m 50s

Tests

Test Name	Status	Flaky	Duration
tests/cli/launcher_test.py::TestLauncherMain::test_debug_mode	✅		1m 26s
tests/cli/launcher_test.py::TestLauncherMain::test_main_run_command	✅		6.2s
tests/cli/launcher_test.py::TestLauncherMain::test_main_run_in_dlc	✅		1.4s
tests/cli/launcher_test.py::TestLauncherMain::test_main_studio_command	✅		319ms
tests/cli/launcher_test.py::TestLauncherMain::test_multi_stage_run	✅		1.7s

Github Test Reporter by CTRF 💚