reset cache for mm models#189
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces methods to reset multimodal and vision encoder caches in the vLLM sampler, ensuring memory is freed after profiling and stale embeddings are cleared after weight updates. The changes are integrated into the GKD and GRPO cookbooks. Feedback includes a suggestion to add a safety check for the reset_mm_cache method to prevent errors on older vLLM versions, a correction for a version number typo in the docstrings, and a recommendation to add the @remote_function decorator to the existing reset_prefix_cache method for consistency in distributed environments.
tastelikefeet
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two vllm reset cache interfaces for multi-modal models, and update cookbooks