test(cypress): drop redundant uncaught:exception suppression in memory-router spec#4826
test(cypress): drop redundant uncaught:exception suppression in memory-router spec#4826voidmatcha wants to merge 2 commits into
Conversation
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/metro-plugin-rock
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/observability-plugin
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Bundle Size Report10 package(s) changed, 31 unchanged. Package dist + ESM entry
Bundle targets
Consumer scenarios
Total dist (raw): 6.81 MB (no change) Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as |


Description
Removes the per-spec
Cypress.on('uncaught:exception', () => false)inapps/router-demo/router-host-2000/cypress/e2e/memory-router.cy.ts.The global handler in
cypress/support/e2e.tsalready allow-lists the only errors this happy-path navigation flow can legitimately emit (the React-bridgeFailed to construct 'HTMLElement'/Illegal constructorand thereact-dom/clientmodule-not-found cases) and returnstrue(fails the test) for everything else. The per-spec handler was strictly weaker: it swallowed every uncaught exception unconditionally, so a genuine regression in this flow would be silently hidden instead of failing. The sibling happy-path specs (remote1.cy.ts,remote2.cy.ts,remote3.cy.ts,host.cy.ts) already run the same federated-remote flow with no per-spec handler, relying on the global allow-list. This bringsmemory-router.cy.tsin line with them and restores real-error visibility.The dedicated error specs (
remote-render-error.cy.ts,remote-resource-error.cy.ts), which deliberately trigger errors, keep their handlers and are intentionally untouched.Related Issue
No separate tracking issue. This is a small test-suite hardening with no behavior change to shipped packages. Happy to open an issue first if you prefer that for traceability.
Types of changes
Checklist
Found while reviewing the test suite with e2e-skills/e2e-reviewer.