This repository was archived by the owner on Feb 15, 2026. It is now read-only.
feat: expose loadMetroConfig & updateManifest helpers#90
Merged
Conversation
…act-native-community/cli dependency
Thegrep01
force-pushed
the
zephyr-api-proto
branch
from
July 15, 2025 14:33
b475569 to
abfe822
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Zephyr monitoring/observability platform with Metro Module Federation and React Native Components (RNC). The integration includes local development dependencies, wrapper commands for build processes, and configuration updates across multiple applications.
Key changes:
- Added local npm links for Zephyr packages using portal dependencies
- Introduced
zephyrCommandWrapperto wrap existing Metro Federation commands - Updated Metro configurations to use async
withZephyr()wrapper - Added new CLI commands and manifest update functionality
Reviewed Changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added portal resolutions for local Zephyr packages |
| packages/plugin-rnc-cli/index.js | Exposed loadMetroConfig command for CLI usage |
| packages/core/src/plugin/manifest.ts | Added updateManifest function for runtime manifest updates |
| packages/core/src/index.ts | Exported updateManifest for external usage |
| packages/core/src/commands/index.ts | Added loadMetroConfig command with debug logging |
| apps/*/react-native.config.js | Added Zephyr-wrapped bundle commands |
| apps/*/metro.config.js | Converted to async configuration with Zephyr integration |
| apps/*/package.json | Added Zephyr dependencies and renamed applications |
Comments suppressed due to low confidence (2)
Thegrep01
force-pushed
the
zephyr-api-proto
branch
2 times, most recently
from
July 21, 2025 11:52
87b321a to
64985a6
Compare
Thegrep01
force-pushed
the
zephyr-api-proto
branch
from
July 21, 2025 11:53
64985a6 to
961a994
Compare
jbroma
reviewed
Jul 31, 2025
jbroma
left a comment
jbroma
left a comment
Member
There was a problem hiding this comment.
Took a look around this PR, would be nice to clear up the API needs before moving forward with this + PR needs some cleaning up
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Thegrep01
force-pushed
the
zephyr-api-proto
branch
from
August 1, 2025 11:10
1adc6cd to
75ca051
Compare
jbroma
reviewed
Aug 2, 2025
jbroma
left a comment
jbroma
left a comment
Member
There was a problem hiding this comment.
please remember to run pnpm lint in the root of the monorepo to fix formatting
jbroma
changed the title
loadMetroConfig & updateManifest helpers
Member
|
@Thegrep01 I've adjusted the PR title and description so we can have this merged sooner 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadMetroConfighelper function for integration with ZephyrupdateManifesthelper function for fixing the remote paths when using Zephyr