fix: publish SSR federation artifacts in multi-environment builds#859
Merged
gioboa merged 4 commits intoJun 26, 2026
Merged
Conversation
tonoizer
force-pushed
the
codex/fix-multi-env-ssr-federation
branch
from
e8e6583 to
7b8c1ae
Compare
commit: |
tonoizer
force-pushed
the
codex/fix-multi-env-ssr-federation
branch
from
7b8c1ae to
d0e8d0d
Compare
tonoizer
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0e8d0d17c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
gioboa
reviewed
Jun 26, 2026
gioboa
left a comment
gioboa
left a comment
Collaborator
There was a problem hiding this comment.
Tests With Different Frameworks
Contributor
Author
|
No problem was my pleasure to help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SSR federation artifacts in multi-environment builds
What changed
ssrenvironment so it cannot overwrite the client manifest.writeBundlehook, publish only the SSR remote entry's reachable chunk graph to the client-served output directory.windowon the server.Why
In environment-split SSR builds, the SSR manifest can replace the public manifest even though it references SSR-only chunks. The advertised SSR entry can also be emitted only into an unserved SSR output directory. Both cases can make browser or server remote loading fall back to incompatible code. Publishing from
writeBundleworks when frameworks such as Nitro orchestrate Vite environments themselves, and walking both output metadata and emitted source keeps the publication graph complete without copying unrelated server output.Validation
pnpm typecheckpnpm test(580 tests)pnpm test:integration(34 tests)pnpm e2e(19 Playwright tests)