fix: gvm-installer zsh incompatible use of ==#468
Open
jwatte wants to merge 1 commit intomoovweb:masterfrom
Open
fix: gvm-installer zsh incompatible use of ==#468jwatte wants to merge 1 commit intomoovweb:masterfrom
jwatte wants to merge 1 commit intomoovweb:masterfrom
Conversation
zsh wants "=" not "==" for test equality. "=" also works in bash. zsh is the default shell on MacOS, so it seems prudent to work by default on that platform.
|
anyone able to merge it? |
|
Bump on getting this merged |
|
why this is not merged yet? |
|
Had the same problem |
|
any reason not to merge? patch looks good |
Author
|
Look, it's only been half a year, and it's a whole full one character of a change - in four different places! - so let's be realistic here. Reviews take time. |
Redaloukil
approved these changes
Jul 20, 2025
There was a problem hiding this comment.
I think we can approve, however, I tried to check with other shells and some fail to run script. for example : > ksh block at line 100 because of the command pushd
It runs with your change on zsh which goes well with the actual installation instructions. I confirm after trying in on my host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zsh wants "=" not "==" for test equality.
"=" also works in bash.
zsh is the default shell on MacOS, so it seems prudent to work by default on that platform.