Add username from CONNECT to client after authenticate succes#660
Open
faceless2 wants to merge 2 commits intomoscajs:mainfrom
Open
Add username from CONNECT to client after authenticate succes#660faceless2 wants to merge 2 commits intomoscajs:mainfrom
faceless2 wants to merge 2 commits intomoscajs:mainfrom
Conversation
Member
|
You should add a unit test that covers this |
Member
Member
|
It makes sense to have the username by default in the client, personally i always add it manually :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re issue #147, the basic requirement in any authentication scheme is knowing the username specified during the CONNECT phase. So I think this really should be in the core API, rather than added by users.
This patch adds a that as the
Client.usernameproperty.