Added server profile design doc in eSignet - #2115
Conversation
Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com>
WalkthroughA new design document describes the Server Profile feature, including global configuration, database mappings, runtime resolution, OIDC/FAPI enforcement for PAR, PKCE, and DPoP, custom profiles, and backward compatibility. ChangesServer Profile Design Document
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com>
Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/design/server-profile.md`:
- Around line 7-10: Document and enforce startup validation for the server
profile configuration: when mosip.esignet.server.profile is anything other than
"none", require matching mandatory server_profile mappings and fail startup with
a configuration error if the profile is unknown or incomplete. Preserve the
existing behavior for the "none" profile and prevent empty mappings from falling
back to client-level configuration.
- Around line 7-10: Update the fapi2.0 server profile documentation and its
corresponding database mappings to either enforce the missing FAPI 2.0
controls—PKCE S256, MTLS or DPoP sender-constrained tokens, and a 60-second
authorization-code lifetime—or rename the profile and descriptions to accurately
reflect the narrower policy. Keep the documented profile behavior and database
configuration consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b4c9f33c-adaa-42e8-b3de-115671c85e37
📒 Files selected for processing (1)
docs/design/server-profile.md
Summary by CodeRabbit