MOSIP-45324-Esignet ui automate not automated test cases from master sheet (MOSIP-22717) - #2210
Conversation
Signed-off-by: Jayesh Kharode <jayesh.kharode@technoforte.co.in>
Signed-off-by: Jayesh Kharode <jayesh.kharode@technoforte.co.in>
|
Warning Review limit reached
Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
WalkthroughThe UI test suite adds claims-free authorize-scope consent coverage, biometric device-discovery assertions, prerequisite VID handling, browser locale configuration, and default-language validation against ChangesAuthorize and consent flows
Biometric login coverage
Locale and language validation
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mohanachandran-s
left a comment
mohanachandran-s
left a comment
There was a problem hiding this comment.
Add the description for the PR
Restore AddIdentity_Vid_Generation_smoke_Pos_UIN for perpetual and temporary VID creation so prerequisite VIDs stay on the dedicated identity, consistent with api-test and separate from the primary login identity. Signed-off-by: Jayesh Kharode <jayesh.kharode@technoforte.co.in> Co-authored-by: Cursor <cursoragent@cursor.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui-test/src/main/java/pages/ConsentPage.java`:
- Around line 448-452: Update waitUntilUserProfilePage() so the navigation log
does not include the OAuth authorization code: remove the query string from
driver.getCurrentUrl() before passing the URL to LOGGER.info. Preserve logging
the non-sensitive URL path and existing wait behavior.
In `@ui-test/src/main/java/pages/LoginOptionsPage.java`:
- Around line 427-429: Replace the hardcoded value returned by
getScanningDevicesPartialText() with the SBI localization resource key for the
scanning-devices message, and update isScanningDevicesMessageDisplayed() and
isRetryScanButtonNotDisplayedWhileScanning() to check it through
isLocalizedTextVisibleWithinBiometricContainer().
In `@ui-test/src/main/java/utils/EsignetUtil.java`:
- Around line 636-664: Centralize the perpetual and temporary VID cache-key
values used by EsignetUtil’s PERPETUAL_VID_CACHE_KEY and TEMPORARY_VID_CACHE_KEY
and VIDManager’s static initializer. Define each literal in one shared
accessible constant and update both consumers to reference it, removing the
duplicate hardcoded values while preserving the existing cache keys.
In `@ui-test/src/main/java/utils/LanguageUtil.java`:
- Around line 107-120: Replace the downloadJson() usage in
LanguageUtil.fetchDefaultLangFromEnvConfig and ResourceBundleLoader with a
URLConnection-based read that sets bounded connect and read timeouts before
obtaining the input stream. Preserve the existing response parsing, locale
behavior, and exception handling in both affected files:
ui-test/src/main/java/utils/LanguageUtil.java (107-120) and
ui-test/src/main/java/utils/ResourceBundleLoader.java (36-68).
In `@ui-test/src/main/java/utils/VIDManager.java`:
- Around line 26-35: Replace the duplicated cache-key literals in the
VID-loading logic of VIDManager with the shared constants or key definitions
from EsignetUtil.java. Update both perpetual and temporary VID lookups while
preserving the existing null, empty-value, and availableVIDs behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b999a833-69dd-4102-9bba-9a9f09cc2baf
📒 Files selected for processing (17)
ui-test/src/main/java/base/BaseTest.javaui-test/src/main/java/pages/ConsentPage.javaui-test/src/main/java/pages/LoginOptionsPage.javaui-test/src/main/java/pages/MultiLanguagePage.javaui-test/src/main/java/stepdefinitions/ConsentStepDefinition.javaui-test/src/main/java/stepdefinitions/LoginOptionsStepDefinition.javaui-test/src/main/java/stepdefinitions/MultiLanguageStepDef.javaui-test/src/main/java/utils/BaseTestUtil.javaui-test/src/main/java/utils/EsignetUtil.javaui-test/src/main/java/utils/LanguageUtil.javaui-test/src/main/java/utils/ResourceBundleLoader.javaui-test/src/main/java/utils/VIDManager.javaui-test/src/main/resources/config.propertiesui-test/src/main/resources/esignetUI/CreateVID/CreateVid.ymlui-test/src/main/resources/featurefiles/ConsentPage.featureui-test/src/main/resources/featurefiles/LoginOptions.featureui-test/src/main/resources/featurefiles/MultiLanguage.feature
Sanitize OAuth URL logging, centralize VID cache keys, use localized scanning message checks, and add HTTP timeouts for env-config downloads. Co-authored-by: Cursor <cursoragent@cursor.com>
Sanitize OAuth URL logging, centralize VID cache keys, use localized scanning message checks, and add HTTP timeouts for env-config downloads. Signed-off-by: Jayesh Kharode <jayesh.kharode@technoforte.co.in> Co-authored-by: Cursor <cursoragent@cursor.com>
zesu22
left a comment
zesu22
left a comment
There was a problem hiding this comment.
approving because @mohanachandran-s already approved it
4 participants
Summary by CodeRabbit
New Features
Bug Fixes
Tests