fix: handle escaped backslash before n/r in double-quoted values#1024
Open
JSap0914 wants to merge 1 commit into
Open
fix: handle escaped backslash before n/r in double-quoted values#1024JSap0914 wants to merge 1 commit into
JSap0914 wants to merge 1 commit into
Conversation
When a double-quoted .env value contains \\n or \\r (an escaped backslash followed by n or r), the two sequential replace() calls incorrectly expanded the sequence. For example KEY="path\\nvalue" produced 'path\' + newline + 'value' instead of the expected literal 'path\nvalue'. Replace the two sequential replacements with a single-pass callback that processes each escape sequence left-to-right: \\n -> newline \\r -> carriage return \\\\ -> single backslash anything else -> kept as-is This correctly handles KEY="path\\nvalue" -> 'path\nvalue' while preserving the existing KEY="expand\nlines" -> 'expand' + LF + 'lines' behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
parse(), when a double-quoted value contains\\\\nor\\\\r(an escaped backslash followed bynorr), the two sequentialreplace()calls misfire. The second backslash plus the letter is consumed as a\\n/\\rescape sequence, leaving an orphaned first backslash and producing an unintended newline/carriage-return.Example
.env:Before (buggy):
path\+ newline +valueAfter (correct):
path\nvalue(literal backslash-n)Fix
Replace the two sequential
replace()calls with a single-pass callback that scans escape sequences left-to-right:\\n→ newline\\r→ carriage return\\\\→ single backslash (new)This correctly handles
\\\\nby first consuming\\\\into a single backslash, then leaving the literalnuntouched.Verification
Three new test cases added (ok 25–27 in test-parse.js). All 199 existing tests continue to pass.