Skip to content

Conversation

@relud
Copy link
Contributor

@relud relud commented Jan 28, 2026

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're kind of treading new ground here, normally this is just a simple type name. I think it should work, but I guess we'll see when this gets to the experimenter CI.

FWIW, it's possible that loads returns a JSON object with integer keys, or for that matter just an integer. However, I don't think that will happen with the ones nimbus-fml is sending and in any case, this is just used for the typecheckers.

So, there's a couple things that may go wrong but I'm still for merging this one and see what happens when you run pyright on the generated code.

@relud
Copy link
Contributor Author

relud commented Jan 28, 2026

normally this is just a simple type name

CI threw NameError: name 'Any' is not defined, so I reduced it to dict

@relud relud added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit 794fb82 Jan 29, 2026
13 checks passed
@relud relud deleted the relud-patch-1 branch January 29, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants