PART3: feat(settings): Migrate fxa-settings from GraphQL to direct auth-client (cutover)#19981
Conversation
This was referenced Feb 2, 2026
d8b0f36 to
5886060
Compare
0f6db37 to
2c6b6b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
fxa-graphql-apiservice adds unnecessary latency and complexity betweenfxa-settingsandfxa-auth-serverThis pull request
ApolloProvider,ApolloClient, and all GQL mutations/queries from the fxa-settings entrypoint and page containersfxa-auth-clientmethods (signInWithAuthPW,getCredentialStatusV2,sendUnblockCode, etc.)account-storage.ts— unified localStorage-based account state replacing the ApolloInMemoryCacheAccountStateContextandAuthStateContextReact contexts for reactive state managementuseAccountDatahook that fetches account, profile, and attached clients data in parallel via auth-clientgql-key-stretch-upgradetoauth-key-stretch-upgrade, now calling auth-client directlygql.ts)@apollo/clientandgraphqlfromfxa-settingsdependenciesPageMfaGuardWithGqlTest(GQL-only test page)Issue
Closes: https://mozilla-hub.atlassian.net/browse/FXA-12995
Checklist
Other Information
Scope: 90 files changed, ~2,600 insertions, ~2,700 deletions
Breaking changes: The
fxa-graphql-apiserver is no longer required forfxa-settingsto function. CSP rules for the GQL endpoint have been removed from content-server configuration.Legacy shim:
gql.tsandcache.tsretain a no-op Apollo cache shim for files not yet migrated (PostVerify, SetPassword, InlineRecoveryKeySetup). These should be cleaned up in a follow-up.