fix(fxa-settings): clean up noisy test output across test suite in fxa-settings#20009
fix(fxa-settings): clean up noisy test output across test suite in fxa-settings#20009
Conversation
vbudhram
force-pushed
the
fix-settings-tests-output
branch
from
5cfd97c to
39d0fb0
Compare
nshirley
left a comment
nshirley
left a comment
There was a problem hiding this comment.
I'm curious your thoughts on adding an env override to disable the log suppression - I like the approach but having an easy way to turn it off would be nice
| }); | ||
|
|
||
| it('debounces OTP resend requests', async () => { | ||
| // Use a deterministic clock so debounce logic is not affected by system load. |
| filter: (msg: string) => boolean | ||
| ): T => | ||
| ((...args: any[]) => { | ||
| if (filter(String(args[0]))) return; |
There was a problem hiding this comment.
nit: having a way to disable the filtering with an explicit ENV var override would be nice. I can see us looking for one of these messages
and I mention because I've seen the Model Validation Errors and Missing field messages, and they imply we're not testing something as we should be so we should probably fix what's causing the issues at some point
| expect(currentIndexProps?.processEmailSubmission).toBeDefined(); | ||
| }); | ||
| await currentIndexProps?.processEmailSubmission(MOCK_EMAIL); | ||
| await act(async () => { |
There was a problem hiding this comment.
Makes me happy seeing these cleaned up again! just give it a few months though, they'll be back
vbudhram
force-pushed
the
fix-settings-tests-output
branch
from
39d0fb0 to
bbe63ce
Compare
nshirley
left a comment
nshirley
left a comment
There was a problem hiding this comment.
Thanks for cleaning these up AND for adding that env flag to disable the output filtering.
2 participants
Because
This pull request
Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-10364
Checklist
Other information (Optional)