Conversation
travis79
approved these changes
Feb 18, 2026
| let cfg = glean_core::InternalConfiguration { | ||
| upload_enabled: true, | ||
| data_path, | ||
| application_id: String::from("glean-bench"), |
Member
There was a problem hiding this comment.
Just curious, why String::from instead of to_string or into (which is used elsewhere in the patch)?
Member
Author
There was a problem hiding this comment.
Good question! In the end these calls are (by now) all about the same.
In rather old Rust there were actually some performance differences between these calls, but that has since been fixed (afaik). So any of the ways is acceptable.
I somehow got into the habit of making it explicit with String::from a while ago. The other uses were left-overs from code I copied together I guess.
I'll send a followup to unify it though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time to contribute back piecemeal the things I build for the new storage.