Consider missing Android placeholders as errors if translation has extra % signs#4037
Merged
mathjazz merged 2 commits intomozilla:mainfrom Mar 25, 2026
Merged
Consider missing Android placeholders as errors if translation has extra % signs#4037mathjazz merged 2 commits intomozilla:mainfrom
% signs#4037mathjazz merged 2 commits intomozilla:mainfrom
Conversation
flodolo
approved these changes
Mar 24, 2026
Collaborator
flodolo
left a comment
flodolo
left a comment
There was a problem hiding this comment.
This seems reasonable, but I have an incredibly hard time following the code with the current variable names.
flodolo
approved these changes
Mar 24, 2026
mathjazz
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4035
See also bug 2025733
This should cover the cases where a placeholder is mistyped so that it doesn't parse as an Android placeholder, but still at least starts with a
%character.