Don't wait depfiles for gcc/clang preprocessed inputs#2665
Don't wait depfiles for gcc/clang preprocessed inputs#2665sylvestre merged 1 commit intomozilla:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2665 +/- ##
==========================================
+ Coverage 74.27% 74.34% +0.06%
==========================================
Files 70 70
Lines 39325 39373 +48
==========================================
+ Hits 29208 29270 +62
+ Misses 10117 10103 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @sylvestre , Friendly ping for this PR (and anothers too, please). I hope you have some time for it. |
292eeec to
410b44c
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
| }, | ||
| ); | ||
| // If the language doesn't need preprocessing, it doesn't generate a dependency file. See issue #2664 | ||
| if language.needs_c_preprocessing() { |
There was a problem hiding this comment.
Cannot do it without explicit external if, because clippy is not happy with if let ... && ... and with if ... && let ...
See rust-lang/rust#53667 for more details
|
please add integration tests for both gcc & clang |
09604df to
7b85b90
Compare
|
Looks like freebsd error is not related to my changes. So, the PR is ready. @sylvestre , I've added the integration tests too |
Fixes #2664