Skip to content

Don't wait depfiles for gcc/clang preprocessed inputs#2665

Merged
sylvestre merged 1 commit intomozilla:mainfrom
AJIOB:fix-asm-depfile
May 4, 2026
Merged

Don't wait depfiles for gcc/clang preprocessed inputs#2665
sylvestre merged 1 commit intomozilla:mainfrom
AJIOB:fix-asm-depfile

Conversation

@AJIOB
Copy link
Copy Markdown
Contributor

@AJIOB AJIOB commented Apr 3, 2026

Fixes #2664

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 96.87500% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.34%. Comparing base (6f7e664) to head (81e96e1).

Files with missing lines Patch % Lines
src/compiler/gcc.rs 96.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2665      +/-   ##
==========================================
+ Coverage   74.27%   74.34%   +0.06%     
==========================================
  Files          70       70              
  Lines       39325    39373      +48     
==========================================
+ Hits        29208    29270      +62     
+ Misses      10117    10103      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AJIOB
Copy link
Copy Markdown
Contributor Author

AJIOB commented Apr 14, 2026

Hi @sylvestre ,

Friendly ping for this PR (and anothers too, please).

I hope you have some time for it.

@AJIOB AJIOB force-pushed the fix-asm-depfile branch 4 times, most recently from 292eeec to 410b44c Compare April 23, 2026 19:28
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 23, 2026

Merging this PR will not alter performance

✅ 60 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing AJIOB:fix-asm-depfile (81e96e1) with main (6f7e664)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread src/compiler/gcc.rs
},
);
// If the language doesn't need preprocessing, it doesn't generate a dependency file. See issue #2664
if language.needs_c_preprocessing() {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot do it without explicit external if, because clippy is not happy with if let ... && ... and with if ... && let ...

See rust-lang/rust#53667 for more details

@sylvestre
Copy link
Copy Markdown
Collaborator

please add integration tests for both gcc & clang
thanks

@AJIOB AJIOB force-pushed the fix-asm-depfile branch 2 times, most recently from 09604df to 7b85b90 Compare April 24, 2026 08:49
@AJIOB
Copy link
Copy Markdown
Contributor Author

AJIOB commented Apr 24, 2026

Looks like freebsd error is not related to my changes.

So, the PR is ready.

@sylvestre , I've added the integration tests too

@AJIOB AJIOB force-pushed the fix-asm-depfile branch from 7b85b90 to 81e96e1 Compare April 30, 2026 13:45
@sylvestre sylvestre merged commit 9ce55d9 into mozilla:main May 4, 2026
52 checks passed
@AJIOB AJIOB deleted the fix-asm-depfile branch May 4, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assembly without preprocessing doesn't ignore depfile

3 participants