feat: add option to not check build server source IP#2709
Open
iTrooz wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2709 +/- ##
==========================================
+ Coverage 74.34% 74.36% +0.02%
==========================================
Files 70 70
Lines 39373 39440 +67
==========================================
+ Hits 29271 29329 +58
- Misses 10102 10111 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
please update the doc and also add a test to check this (esp in case of mismatch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
This PR adds an option to be able to disable the scheduler checking the IP of the build server when connecting.
While this option is useful in some cases, it can be annoying for more complex setups. For example, I am currently using sccache on servers behind a NAT that I do not control, and use port redirection services (like ngrok) to talk to the build servers.
This means that a build server does not have a single "public IP", but use a different IP when initiating or receiving connections.
Currently, I'm getting around that by adding a reverse-proxy in front of the scheduler, adding a fake X-Real-IP header, to force the scheduler to accept build server connections from any source IP. But I'd like to simplify my setup, hence this option
The default behaviour is unchanged