Skip to content

feat: add option to not check build server source IP#2709

Open
iTrooz wants to merge 6 commits into
mozilla:mainfrom
iTrooz:check_server_ip
Open

feat: add option to not check build server source IP#2709
iTrooz wants to merge 6 commits into
mozilla:mainfrom
iTrooz:check_server_ip

Conversation

@iTrooz
Copy link
Copy Markdown
Contributor

@iTrooz iTrooz commented May 14, 2026

Hello !

This PR adds an option to be able to disable the scheduler checking the IP of the build server when connecting.
While this option is useful in some cases, it can be annoying for more complex setups. For example, I am currently using sccache on servers behind a NAT that I do not control, and use port redirection services (like ngrok) to talk to the build servers.
This means that a build server does not have a single "public IP", but use a different IP when initiating or receiving connections.

Currently, I'm getting around that by adding a reverse-proxy in front of the scheduler, adding a fake X-Real-IP header, to force the scheduler to accept build server connections from any source IP. But I'd like to simplify my setup, hence this option

The default behaviour is unchanged

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2026

Codecov Report

❌ Patch coverage is 73.84615% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.36%. Comparing base (c0db872) to head (2b9f6d5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dist/http.rs 78.33% 13 Missing ⚠️
src/bin/sccache-dist/main.rs 0.00% 2 Missing ⚠️
src/config.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2709      +/-   ##
==========================================
+ Coverage   74.34%   74.36%   +0.02%     
==========================================
  Files          70       70              
  Lines       39373    39440      +67     
==========================================
+ Hits        29271    29329      +58     
- Misses      10102    10111       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre
Copy link
Copy Markdown
Collaborator

please update the doc and also add a test to check this (esp in case of mismatch)
thanks

@iTrooz iTrooz force-pushed the check_server_ip branch from 6be7d77 to ca93cfb Compare May 15, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants