context_menu.lua: set user-data/mpv/context-menu/open

[guidocella]

Closes #17428.

Questions:

• Should be context-menu or context_menu?
• Should this instead be a top-level property that also shows the Windows menu status?
• Or should the Windows menu also update user-data?

[dyphire]

The Windows menu does not need to update user-data, it is located at the top level of the window and is not affected by OSC. It can be displayed together with various OSC and OSD menus.

[guidocella]

The main use case would be for pausing when the context menu is open (#16816 (comment))

(context_menu.lua also renders just fine with osc.lua or ModernZ so I guess it's a uosc problem?)

[dyphire]

The main use case would be for pausing when the context menu is open (#16816 (comment))

(context_menu.lua also renders just fine with osc.lua or ModernZ so I guess it's a uosc problem?)

Yes, I found this problem while using uosc.

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-v0.41.0-dev-g4157fc682-pr17429-22189058595-aarch64-pc-windows-msvc
• mpv-v0.41.0-dev-g4157fc682-pr17429-22189058595-aarch64-pc-windows-msvc-pdb
• mpv-v0.41.0-dev-g4157fc682-pr17429-22189058595-i686-w64-mingw32
• mpv-v0.41.0-dev-g4157fc682-pr17429-22189058595-x86_64-pc-windows-msvc
• mpv-v0.41.0-dev-g4157fc682-pr17429-22189058595-x86_64-pc-windows-msvc-pdb
• mpv-v0.41.0-dev-g4157fc682-pr17429-22189058595-x86_64-w64-mingw32

macOS

• mpv-v0.41.0-dev-g4157fc682-pr17429-22189058595-macos-14-arm
• mpv-v0.41.0-dev-g4157fc682-pr17429-22189058595-macos-15-arm
• mpv-v0.41.0-dev-g4157fc682-pr17429-22189058595-macos-15-intel
• mpv-v0.41.0-dev-g4157fc682-pr17429-22189058595-macos-26-arm

[Keith94]

Or should the Windows menu also update user-data?

Does that mean it can be supported with native Windows menu? If so that would be nice.

The feature is working with an autoprofile. If I had one nitpick, the first menu entry still reads "Pause" at the same time pause is activated. Maybe it should say "Play/Pause" instead?

[context-menu-pause]
profile-cond=p['user-data/mpv/context-menu/open']
profile-restore=copy
pause

[guidocella]

The Windows code can easily set and unset a property, the question is how the API should be and whether it needs to be different for the Windows menu and the script.

You can change the first item to Play/Pause in your menu.conf.

[kasper93]

LGTM, thanks!