vo: officially deprecate vo_vaapi#17430
Conversation
Dudemanguy
force-pushed
the
nuke-bad-vos
branch
from
65f45d2 to
e9af840
Compare
|
ach ja ze MVP dewelopper removing ze best VO zis must be a konspirazee I will blog about zis injustice ja |
Dudemanguy
force-pushed
the
nuke-bad-vos
branch
from
e9af840 to
20fcd01
Compare
Dudemanguy
changed the title
|
The legacy intel-vaapi-driver doesn't have vaPutSurface so I don't think this has worked for a very long time. |
|
I don't own a single device where this works correctly. |
Using vo_vaapi has already been heavily discouraged for years since years since 5c313f1. More importantly, it's just fundamentally broken on most hardware, serves no real purpose, and well we shouldn't just ship broken stuff. vo_vaapi largely only ever worked correctly on some intel hardware. The VO relies on certain API calls that other vendors never implemented so things like the OSD and subtitles are just never going to work. This largely has no reason to exist either. If you're looking for efficient playback, you can use vo_gpu/vo_gpu_next in dumb mode with vaapi decoding. You can also use vo_dmabuf_wayland with vaapi as well to avoid even more GPU to CPU copies and theoretically be even more efficient.
Dudemanguy
force-pushed
the
nuke-bad-vos
branch
from
20fcd01 to
1f51ab2
Compare
@sfan5 said on IRC, that it works fine for him, except some mouse handling bug. |
|
This uses the generic x11 event code for mouse handling. |
|
The bug is this: Resize the window to be 2x, then the OSC will show not when the mouse is at the bottom but half-way to the window height. |
kasper93
left a comment
kasper93
left a comment
There was a problem hiding this comment.
I don't mind the change, although removing features which doesn't cause much maintenance is not great for people who still uses them.
6 participants
Using vo_vaapi has already been heavily discouraged for years since years since 5c313f1. More importantly, it's just fundamentally broken on most hardware, serves no real purpose, and well we shouldn't just ship broken stuff. vo_vaapi largely only ever worked correctly on some intel hardware. The VO relies on certain API calls that other vendors never implemented so things like the OSD and subtitles are just never going to work. This largely has no reason to exist either. If you're looking for efficient playback, you can use vo_gpu/vo_gpu_next in dumb mode with vaapi decoding. You can also use vo_dmabuf_wayland with vaapi as well to avoid even more GPU to CPU copies and theoretically be even more efficient.