vo: prefer dmabuf_wayland over other fallback VOs#17497
vo: prefer dmabuf_wayland over other fallback VOs#17497kasper93 wants to merge 1 commit intompv-player:masterfrom
Conversation
|
Also the documentation says:
Doesn't this mean that with the default config, it will always do something that is not recommended? |
If you want quality use gpu/gpu-next, if you want speed use dmabuf_wayland. wlshm is neither of those.
wslhm doesn't support mapping hardware frames at all. Those extra steps described here, are basically the possibly frame upload and conversion (if needed), which will happen with any and all rendering pipelines at some point, only using hwdec can take advantage of fully on GPU processing. Are you familiar with dmabuf_wayland can support all those things, it's basically wlshm on steroids. Allowing mapping hardware frame, allowing sending yuv frame direction. |
On most hardware the speed advantage is minimal compared to
wlshm has compatibility. dmabuf-wayland does not, and it is less compatible than gpu/gpu-next on most hardware. #14627 The context of this comparision is as a fallback for gpu/gpu-next, and I consider compatibility a higher priority here.
For my second point I am not making any wlshm comparision. The documentation points out its many caveats and encourages users to use gpu/gpu-next instead. |
|
Compatibility is not a problem if it properly falls back during the autoprobe. |
The same can be said for hwdec. It is not a problem if it properly falls back to software decoding when it does not work. Given that dmabuf-wayland is highly dependent on GPU hardware and drivers, are you sure that it knows 100% when it does not work properly? Because the same point is used to argue against enabling hwdec by default. |
|
I really don't like bogus arguments. hwdec is known to cause gpu resets or permanent stalls on machines with bugged drivers. |
|
Just remembered but if we go forward with this, we can probably remove Also we could remove |
No description provided.