command: log menu-data changes at trace level instead of verbose#17498
Open
guidocella wants to merge 1 commit intompv-player:masterfrom
Open
command: log menu-data changes at trace level instead of verbose#17498guidocella wants to merge 1 commit intompv-player:masterfrom
guidocella wants to merge 1 commit intompv-player:masterfrom
Conversation
Avoid spamming the log.
sfan5
approved these changes
Mar 3, 2026
na-na-hi
reviewed
Mar 3, 2026
| { | ||
| struct command_ctx *cmd = ctx->command_ctx; | ||
| int r = m_property_do(ctx->log, cmd->properties, name, action, val, ctx); | ||
| int level = strcmp(name, "menu-data") ? MSGL_V : MSGL_TRACE; |
Contributor
There was a problem hiding this comment.
Instead of special casing one property it should be a flag that can be applied to similar properties like user-data.
Member
There was a problem hiding this comment.
Also, we might want revamp how props are printed. Could do "setting property name" on verbose and "setting property name: value" or higher level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid spamming the log.