meson: bump min libplacebo version to v7.360.0#17513
meson: bump min libplacebo version to v7.360.0#17513llyyr wants to merge 2 commits intompv-player:masterfrom
Conversation
This version contains critical fixes to swapchain selection, correct mapping of sRGB TRC as well as fix for gpu hangs on anv. Bump the minimum version because the mpv experience with previous version shouldn't be endorsed or be considered acceptable by upstream.
llyyr
force-pushed
the
bump-libplacebo360
branch
from
a00896a to
e838320
Compare
|
Need to resolve CI situation before merge. Probably clone to subprojects/libplacebo will be enough in correct places. |
|
I'm not sure what the problem is with the msvc build, and I can't really test it locally either |
llyyr
force-pushed
the
bump-libplacebo360
branch
from
cc16115 to
5eed471
Compare
| .vsync_duration = can_interpolate ? frame->ideal_frame_vsync_duration : 0, | ||
| ); | ||
| #if PL_API_VER >= 340 | ||
| qparams.drift_compensation = 0; |
There was a problem hiding this comment.
should be put in the init list above
| .interpolation_threshold = opts->interpolation_threshold, | ||
| ); | ||
| #if PL_API_VER >= 340 | ||
| qparams.drift_compensation = 0; |
There was a problem hiding this comment.
should be put in the init list above
| #if PL_API_VER >= 340 | ||
| qparams.drift_compensation = 0; | ||
| #endif | ||
| qparams.drift_compensation = 0; |
There was a problem hiding this comment.
should be put in the init list above
| params->repr.sys != PL_COLOR_SYSTEM_YCGCO | ||
| #if PL_API_VER >= 358 | ||
| && params->repr.sys != PL_COLOR_SYSTEM_YCGCO_RE | ||
| && params->repr.sys != PL_COLOR_SYSTEM_YCGCO_RO |
There was a problem hiding this comment.
style can be adjusted to match above
|
on a side note, bumping the version will prevent builds on macOS that are 'properly' working till #17258 |
|
We can wait a bit then, but there won't be any movement on it until a report to MoltenVK is filed. none of us can test moltenvk since we don't own it. The commit doesn't look wrong to me, and validation layer doesn't report anything either. Maybe you could do partial reverts of the commit to see the part that causes the issue? you can probably get an even minimal reproducer by using plplay from libplacebo, instead of mpv. |
3 participants
This version contains critical fixes to swapchain selection, correct mapping of sRGB TRC as well as fix for gpu hangs on anv. Bump the minimum version because the mpv experience with previous version shouldn't be endorsed or be considered acceptable by upstream.