player/command: add default-value/choices arg fields to command-list#17516
Open
zenodity wants to merge 1 commit intompv-player:masterfrom
Open
player/command: add default-value/choices arg fields to command-list#17516zenodity wants to merge 1 commit intompv-player:masterfrom
zenodity wants to merge 1 commit intompv-player:masterfrom
Conversation
Contributor
|
This is great for commands.lua which currently hardcodes flags. |
kasper93
reviewed
Mar 7, 2026
player/command.c
Outdated
| node_map_add_string(ae, "type", a->type->name); | ||
| node_map_add_flag(ae, "optional", a->flags & MP_CMD_OPT_ARG); | ||
| if (a->defval) { | ||
| if (a->type == &m_option_type_int) { |
Member
There was a problem hiding this comment.
You can use m_option_get_node to avoid this ladder of conditions.
Contributor
Author
There was a problem hiding this comment.
Updated. Ready for testing.
llyyr
reviewed
Mar 7, 2026
player/command.c
Outdated
| for (int j = 0; alt[j].name; j++) { | ||
| struct mpv_node *ce = node_array_add(choices, MPV_FORMAT_NONE); | ||
| ce->format = MPV_FORMAT_STRING; | ||
| ce->u.string = talloc_strdup(NULL, alt[j].name); |
Contributor
There was a problem hiding this comment.
this strdup is not parented to anything, so we're leaking here
Contributor
Author
There was a problem hiding this comment.
i think i've fixed this. @kasper93 has said he will test this later.
Add optional 'default-value' and 'choices' fields where appropriate for command arguments in the 'command-list' property. Update documentation to reflect the command-list schema change.
zenodity
force-pushed
the
extend-command-list
branch
from
a6c8195 to
b500854
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional 'default-value' and 'choices' fields where appropriate for command arguments in the 'command-list' property. Update documentation to reflect the command-list schema change.
Aligns command-list schema with option-info schema.
Partial output from libmpv "command-list" property:
[{ "name": "seek", "args": [{ "name": "target", "type": "Time", "optional": false }, { "name": "flags", "type": "Flags", "optional": false, "default-value": "relative", "choices": ["relative", "-", "absolute-percent", "absolute", "relative-percent", "keyframes", "exact"] }, { "name": "legacy", "type": "Choice", "optional": true, "choices": ["unused", "default-precise", "keyframes", "exact"] } ], "vararg": false }, { "name": "frame-step", "args": [{ "name": "frames", "type": "Integer", "optional": false, "default-value": 1 }, { "name": "flags", "type": "Choice", "optional": true, "choices": ["play", "seek", "mute"] } ], "vararg": false }]