command: reject negative offset for overlay-add#17521
Merged
sfan5 merged 1 commit intompv-player:masterfrom Mar 9, 2026
Merged
command: reject negative offset for overlay-add#17521sfan5 merged 1 commit intompv-player:masterfrom
sfan5 merged 1 commit intompv-player:masterfrom
Conversation
sfan5
changed the title
N-R-K
approved these changes
Mar 8, 2026
| fd = open(file, O_RDONLY | O_BINARY | O_CLOEXEC); | ||
| } | ||
| int map_size = 0; | ||
| size_t map_size = 0; |
Contributor
There was a problem hiding this comment.
Not touching this would be nice as it'd avoid unnecessary conflict with #17520. Not a big deal tho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in theory someone could have been using a negative offset with the pointer argument, but that doesn't really make sense when you can just adjust the pointer value yourself before calling.