misc/path_utils: add mp_get_ext()#17531
Open
guidocella wants to merge 4 commits intompv-player:masterfrom
Open
misc/path_utils: add mp_get_ext()#17531guidocella wants to merge 4 commits intompv-player:masterfrom
guidocella wants to merge 4 commits intompv-player:masterfrom
Conversation
This is simpler and will allow making mp_splitext() static.
This is easier to understand than mp_splitext(s, NULL);
It is no longer used anywhere. Also rename it to mp_split_path().
Member
|
Why do we even have duplicated this functionally? Why not call |
Contributor
Author
|
Yeah I wanted to make one wrap the other afterwards since only mp_splitpath handles multiple leading dots and backslash separators. Or we can just leave only the bstr functions. |
Member
Yes, that works. Unless it makes it complicated on calls, then can have simple wrapper. |
Contributor
Author
|
Actually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
video/out/vo_gpu_next: use bstr_strip_ext()
This is simpler and will allow making mp_splitext() static.
misc/path_utils: add mp_get_ext()
This is easier to understand than mp_splitext(s, NULL);
various: use mp_get_ext()
misc/path_utils: make mp_splitpath() static
It is no longer used anywhere. Also rename it to mp_split_path().