Fix incorrect rotation of some LODs after using removeGameWorld#4734
Open
FileEX wants to merge 1 commit intomultitheftauto:masterfrom
Open
Fix incorrect rotation of some LODs after using removeGameWorld#4734FileEX wants to merge 1 commit intomultitheftauto:masterfrom
FileEX wants to merge 1 commit intomultitheftauto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In commit a550bbf, matrix removal was added because it was related to a crash with buildings created via
createBuilding. The mentioned commit removes the matrices permanently, never restoring them.Motivation
Fixed #4711
Test plan
crun removeGameWorld
crun restoreGameWorld
Look at the vinewood sign
Checklist