Skip to content

Fix return types for Doctrine\Persistence\Proxy implementations #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnapoli merged 1 commit into from
Apr 29, 2025
+10 −6
Merged

Fix return types for Doctrine\Persistence\Proxy implementations #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fixtures/f013/A.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace DeepCopy\f013;

use BadMethodCallException;
use Doctrine\Persistence\Proxy;

class A implements Proxy
Expand All @@ -11,14 +12,15 @@ class A implements Proxy
/**
* @inheritdoc
*/
public function __load()
public function __load(): void
{
}

/**
* @inheritdoc
*/
public function __isInitialized()
public function __isInitialized(): bool
{
throw new BadMethodCallException();
}
}
6 changes: 4 additions & 2 deletions fixtures/f013/B.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace DeepCopy\f013;

use BadMethodCallException;
use Doctrine\Persistence\Proxy;

class B implements Proxy
Expand All @@ -11,15 +12,16 @@ class B implements Proxy
/**
* @inheritdoc
*/
public function __load()
public function __load(): void
{
}

/**
* @inheritdoc
*/
public function __isInitialized()
public function __isInitialized(): bool
{
throw new BadMethodCallException();
}

public function getFoo()
Expand Down
4 changes: 2 additions & 2 deletions tests/DeepCopyTest/Matcher/Doctrine/DoctrineProxyMatcherTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ class FooProxy implements Proxy
/**
* @inheritdoc
*/
public function __load()
public function __load(): void
{
throw new BadMethodCallException();
}

/**
* @inheritdoc
*/
public function __isInitialized()
public function __isInitialized(): bool
{
throw new BadMethodCallException();
}
Expand Down