test: address AI findings in unit.test.mjs#82
Merged
Conversation
- Replace hardcoded token-like string with a clearly fake TEST_TOKEN constant so it can't be mistaken for a real secret. - Assert that get() throws after clear() in the re-creation test to verify the instance is actually removed before re-booting. Signed-off-by: kurok <22548029+kurok@users.noreply.github.com>
kurok
force-pushed
the
fix/ai-findings-unit-test
branch
from
2f12b21 to
abe2574
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 2 GitHub AI code-quality findings reported on
test/unit.test.mjs.Findings addressed
Hardcoded token in test configuration — the
tokenvalue used areal-looking UUID-style string (
XXXXXXXX-eb8e-5f25-fad2-...) thatcould be mistaken for a live secret. Replaced it with a clearly fake
TEST_TOKEN = 'test-not-a-real-token'constant referenced frombootOpts.Missing assertion after
clear()— the "should clear a client andallow re-creation" test re-booted the client without first verifying
the cleared instance was actually removed. Added
expect(() => VaultClient.get('primaryClient')).to.throw(Error, 'Invalid instance name')immediately after
clear()to confirm the instance is gone beforere-creation.
Verification
npx mocha "test/unit.test.mjs"— all 6 tests pass.