Make CORS configurable and disabled by default#1121
Merged
Conversation
Co-authored-by: quake <8990+quake@users.noreply.github.com>
Co-authored-by: quake <8990+quake@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add CORS support to HTTP RPC responses
Add CORS support to HTTP RPC server
Feb 10, 2026
quake
reviewed
Feb 19, 2026
Co-authored-by: quake <8990+quake@users.noreply.github.com>
Copilot
AI
changed the title
Add CORS support to HTTP RPC server
Make CORS configurable and disabled by default
Feb 19, 2026
quake
approved these changes
Feb 19, 2026
Zhangcy0x3
pushed a commit
to Zhangcy0x3/fiber
that referenced
this pull request
Mar 12, 2026
* Initial plan * Add CORS support to HTTP RPC server Co-authored-by: quake <8990+quake@users.noreply.github.com> * Add clarifying comment about CORS middleware ordering Co-authored-by: quake <8990+quake@users.noreply.github.com> * Make CORS configurable and disabled by default Co-authored-by: quake <8990+quake@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: quake <8990+quake@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CORS was previously always enabled with wildcard origins (
*). This makes it configurable and disables it by default for security.Changes
Configuration (
RpcConfig):cors_enabled: bool(default:false)cors_allowed_origins: Vec<String>(empty = wildcard when enabled)--rpc-cors-enabled,--rpc-cors-allowed-origins), and environment variablesImplementation:
cors_enabledAccess-Control-Allow-Origin: *Testing:
Usage
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.