Skip to content

Support random functions for neuromodulated spikes#1278

Merged
clinssen merged 9 commits intonest:mainfrom
pnbabu:random_funcs_neuromod
Mar 23, 2026
Merged

Support random functions for neuromodulated spikes#1278
clinssen merged 9 commits intonest:mainfrom
pnbabu:random_funcs_neuromod

Conversation

@pnbabu
Copy link
Copy Markdown
Contributor

@pnbabu pnbabu commented Dec 4, 2025

Fixes #1277

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2025

🐰 Bencher Report

Branch1278/merge
Testbedubuntu-latest

🚨 1 Alert

IterationBenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
0tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapseLatency
seconds (s)
📈 plot
🚷 threshold
🚨 alert (🔔)
3.83 s
(+12.79%)Baseline: 3.40 s
3.74 s
(102.54%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
🚨 view alert (🔔)
3.83 s
(+12.79%)Baseline: 3.40 s
3.74 s
(102.54%)

BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
🚨 view alert (🔔)
3.19 s
(-5.89%)Baseline: 3.39 s
3.73 s
(85.55%)

BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
🚨 view alert (🔔)
3.19 s
(-5.83%)Baseline: 3.39 s
3.73 s
(85.61%)

🐰 View full continuous benchmarking report in Bencher

@pnbabu pnbabu marked this pull request as ready for review January 15, 2026 14:51
@pnbabu pnbabu requested a review from clinssen January 15, 2026 14:52
Comment thread tests/nest_tests/test_random_functions_neuromod_spikes.py Outdated
@pnbabu pnbabu requested a review from clinssen March 1, 2026 17:54
@clinssen
Copy link
Copy Markdown
Contributor

clinssen commented Mar 1, 2026

Would you be okay changing the implementation to this? pnbabu#8 I just wanted to see if this would work, but it looks like it indeed worked out of the box!

pnbabu and others added 3 commits March 5, 2026 16:25
@clinssen clinssen merged commit 0c7e4de into nest:main Mar 23, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random number functions do not work when used inside an onReceive block for neuromodulated spikes

2 participants