feat(compiler): add allow-outside-paths flag for opt-in path confinement - #3464
Open
AdrianoCLeao wants to merge 1 commit into
Open
feat(compiler): add allow-outside-paths flag for opt-in path confinement#3464AdrianoCLeao wants to merge 1 commit into
AdrianoCLeao wants to merge 1 commit into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issues #3454 and #3456 reported that
compilerOptions.deleteOutDirandassets[].outDiraccept arbitrary paths without validation, allowing attackers to craft repositories whosenest builddeletes or writes files outside the project directory (e.g."outDir": "../../etc").PRs #3455 and #3457 fixed those vulnerabilities with strict path validation, but were reverted (#3461, #3462) because #3460 reported a regression: projects that intentionally output to paths outside the package boundary (e.g. monorepo setups) broke without any opt-out.
Issue Number: #3463
What is the new behavior?
A new
allowOutsidePathsflag is added tocompilerOptions:true/ not set (default)falseoutDir,tsBuildInfoFile, andassets[].outDirmust resolve inside the project directory; a descriptive error is thrown otherwise{ "compilerOptions": { "allowOutsidePaths": false } }Validation logic (when
allowOutsidePaths: false)deleteOutDir: Before callingfs.rm, bothoutDirandtsBuildInfoFileare resolved againstprocess.cwd(). If either resolves to the project root or escapes it (via..traversal or an absolute path outside), an error is thrown before any deletion occurs.assets[].outDir: Each asset destination is resolved before copy/unlink. Same rejection criteria apply.The plan is to flip the default to
falsein v12.Does this PR introduce a breaking change?