fix: resolve default known hosts for strict SSH - #26
Open
hshimomura wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Strict SSH host-key verification is enabled by default, but go-netconf does not
configure a
known_hostssource for scrapligo. As a result, secure connectionsfail while building the SSH transport with:
Change
When
InsecureSkipVerifyis false, add scrapligo'sWithSSHKnownHostsFileSystem()option. Scrapligo then resolves the standardfiles in this order:
~/.ssh/known_hosts/etc/ssh/ssh_known_hostsThe explicit insecure path remains unchanged and continues to use
WithAuthNoStrictKey().Security behavior
This does not introduce trust-on-first-use or weaken verification. Strict mode
still requires a matching entry in a standard
known_hostsfile, and failsclosed when no usable file or matching host key is present.
Validation
go test -race ./...~/.ssh/known_hostsknown_hostslookupgit diff --checkAs a downstream integration check,
terraform-provider-iosxev1.0.0 builtagainst this change completed a refresh-enabled CML plan with
IOSXE_INSECURE=falseacross 22 imported resources, with zero changes.