Upgrade dependencies and fix dark mode styling#2715
Draft
Conversation
- Set up Vitest with React Testing Library and jsdom - Create comprehensive mocks for Docusaurus modules - Add 318 tests across 20 test files covering: - All custom components (Grid, Callout, Install, OneLineInstall, etc.) - Theme overrides (ColorModeToggle, Details, EditThisPage, DocItem) - Data and pages (News.js, index.js redirect) - Add snapshot tests for regression detection - Configure coverage reporting with v8 provider - Add test scripts: test, test:run, test:coverage, test:ui Coverage for non-AskNetdata components: 100% statements, 100% lines
- React 18 → 19 - Tailwind CSS 2 → 4 (CSS-first configuration) - TypeScript 4 → 5.7 - Docusaurus 3.8 → 3.9 - All other dependencies updated to latest Tailwind 4 migration changes: - Add postcss.config.js for @tailwindcss/postcss - Update tailwind.config.js (remove deprecated options) - Update custom.css (@import "tailwindcss", @config directive) - Replace @apply in CSS module with inline styles Update test snapshots for React 19 (className → class)
- Fix Docusaurus v4 deprecation: move onBrokenMarkdownLinks to markdown.hooks - Fix dark mode text colors for headings (was green, now gray) - Fix dark mode link colors (green with intensity change on hover) - Fix light mode links to match dark mode behavior (green links) - Fix code blocks: proper backgrounds and font colors per theme - Fix inline code visibility in dark mode - Fix details/expandable elements backgrounds for both themes - Fix Mermaid diagram text colors (node labels dark, edge labels light) - Fix Prism syntax highlighting colors for both themes - Set code block line-height to 1.0 for ASCII art
✅ Deploy Preview for netdata-docusaurus ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
New Test Suite (318 tests)
Dependency Upgrades
Tailwind 4 Migration
Dark Mode Fixes
Light Mode Improvements
Other
Test plan
npm test- 318 tests passing