fix: address flaky integration tests#7890
Merged
Conversation
📊 Benchmark resultsComparing with 4a57375
|
d5e2c89 to
aff59d3
Compare
VitaliyR
reviewed
Jan 23, 2026
serhalp
reviewed
Jan 23, 2026
khendrikse
approved these changes
Jan 26, 2026
serhalp
reviewed
Jan 26, 2026
Comment on lines
16
to
20
| // @ts-expect-error -- accessing private members for testing | ||
| registry.buildPending = false | ||
| // @ts-expect-error -- accessing private members for testing | ||
| registry.buildPromise = null | ||
| // @ts-expect-error -- accessing private members for testing |
Member
There was a problem hiding this comment.
Don't sink your day into this, but could you take a few mins to see if we can avoid adding all these @ts-expect-errors? 🙏🏼
khendrikse
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fix 1:
Multiple file watcher events (onAdd, onChange) could trigger concurrent build() calls, causing race conditions where the bundler accessed functionConfigs[name] before it was populated .
now only one build runs at a time, and when the current build completes, it checks buildPending and runs another build if needed
Fix 2:
tests/integration/utils/dev-server.ts waited up to 90s with no useful error message, now on timeout it should shows the actual server output so far for debugging
Fix 3:
In tests/integration/commands/init/init.test.ts answerWithValue(CONFIRM) sent ['\n', '\n'] (two newlines), which was causing the second newline to answer the wrong prompt.
Now it should use a single CONFIRM for list/confirm selections, so that prompts are answered correctly and the netlify.toml gets created
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)