Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 27, 2026

Removes old API calls and replaces with the new one from @nextcloud/files

@juliusknorr juliusknorr force-pushed the fix/sidebar branch 2 times, most recently from d4780f0 to 1cb1c2d Compare January 27, 2026 16:16
@juliusknorr
Copy link
Member Author

Reported the talk failures to the talk team, does not look related to our code base

@juliusknorr juliusknorr force-pushed the fix/sidebar branch 2 times, most recently from b1e1571 to 9b8231b Compare January 27, 2026 20:09
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Jan 27, 2026
@juliusknorr juliusknorr marked this pull request as ready for review January 27, 2026 20:09
@juliusknorr juliusknorr requested a review from elzody as a code owner January 27, 2026 20:09
@juliusknorr
Copy link
Member Author

/backport to stable33

Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks

edit: I think actually something is wrong still with the sidebar tests. Will look into that.

@juliusknorr
Copy link
Member Author

I amended a fix for the versions sidebar

@elzody
Copy link
Contributor

elzody commented Jan 27, 2026

Still getting a console error that might affect the versions tab test.

Error: Cannot set sidebar tab 'files_versions' because it is not available for the current context.

I don't think it's anything wrong here though, seems like something else is going on? As far as I can tell it should have the right context since it's being set directly before.

@juliusknorr
Copy link
Member Author

Strange, it worked in my local test

@juliusknorr
Copy link
Member Author

Strange, it worked once, but now i also see this locally

@juliusknorr
Copy link
Member Author

Hotfix added and reported at nextcloud-libraries/nextcloud-files#1474

Signed-off-by: Julius Knorr <[email protected]>

fix: Hotfix to properly apply node type

Signed-off-by: Julius Knorr <[email protected]>
@juliusknorr
Copy link
Member Author

Well no, different story. I failed to resolve a promise for the node object 🙈

Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem like any of the remaining failures are related to this PR, so we can probably force-merge it already and fix those separately for now.

@juliusknorr juliusknorr merged commit 26af99b into main Jan 28, 2026
42 of 48 checks passed
@juliusknorr juliusknorr deleted the fix/sidebar branch January 28, 2026 07:01
Comment on lines +439 to +440
sidebar?.open(node)
sidebar?.setActiveTab('files_versions')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also short cut this:

Suggested change
sidebar?.open(node)
sidebar?.setActiveTab('files_versions')
sidebar?.open(node, 'files_versions')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants