-
Notifications
You must be signed in to change notification settings - Fork 140
fix: Properly handle sidebar in 33 #5294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d4780f0 to
1cb1c2d
Compare
|
Reported the talk failures to the talk team, does not look related to our code base |
b1e1571 to
9b8231b
Compare
|
/backport to stable33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks
edit: I think actually something is wrong still with the sidebar tests. Will look into that.
9b8231b to
d01b64b
Compare
|
I amended a fix for the versions sidebar |
d01b64b to
b0c9a03
Compare
|
Still getting a console error that might affect the versions tab test.
I don't think it's anything wrong here though, seems like something else is going on? As far as I can tell it should have the right context since it's being set directly before. |
|
Strange, it worked in my local test |
|
Strange, it worked once, but now i also see this locally |
b0c9a03 to
81bf41d
Compare
|
Hotfix added and reported at nextcloud-libraries/nextcloud-files#1474 |
Signed-off-by: Julius Knorr <[email protected]> fix: Hotfix to properly apply node type Signed-off-by: Julius Knorr <[email protected]>
81bf41d to
2e1c955
Compare
|
Well no, different story. I failed to resolve a promise for the node object 🙈 |
elzody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not seem like any of the remaining failures are related to this PR, so we can probably force-merge it already and fix those separately for now.
| sidebar?.open(node) | ||
| sidebar?.setActiveTab('files_versions') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also short cut this:
| sidebar?.open(node) | |
| sidebar?.setActiveTab('files_versions') | |
| sidebar?.open(node, 'files_versions') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice 👍
Removes old API calls and replaces with the new one from
@nextcloud/files