Skip to content

Fix does not contains function#2670

Open
taiebot wants to merge 1 commit into
nextcloud:mainfrom
taiebot:Fix-does-not-contain
Open

Fix does not contains function#2670
taiebot wants to merge 1 commit into
nextcloud:mainfrom
taiebot:Fix-does-not-contain

Conversation

@taiebot
Copy link
Copy Markdown

@taiebot taiebot commented May 18, 2026

This time this is a tested fix.

This is entirely based from Claude AI. I tested multiple solutions from other AI and this one is the only one which works.

This correctly picks up empty cells as does not contain, if multiple users are present it does select the correct rows etc...
Tested only with groups and not circles

Will fix #2597

Some screenshots

image image

Signed-off-by: taiebot <dedreuil@yahoo.fr>
@taiebot taiebot requested review from blizzz and enjeck as code owners May 18, 2026 18:30
Copy link
Copy Markdown
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add video showing the flow I described at #2658 (comment)

@taiebot
Copy link
Copy Markdown
Author

taiebot commented May 20, 2026

Ok here we are

Sorry for the poor quality of the gif. I did compare contains and not contain to show the difference

=> current behaviour

Mainbranch-ezgif com-cut

=> With patch
ezgif com-cut

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter Does-not-Contains for groups and user column does not work

2 participants