Skip to content

Conversation

@sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Jan 28, 2026

fix #5765

some other followups:

  • There is a bug with rescheduling/editing scheduled thread replies.
  • Removed native android emoji library as it does not have inbuilt search and delete emoji options. I used vanniktech library for this PR and this will be improved in future.
  • More testing should be done on rescheduling, editing all messages (thread, replies, text scheduled messages)

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as draft January 28, 2026 18:49
@sowjanyakch sowjanyakch force-pushed the fix/5765/ScheduledMessagesUI branch from 1fe30e6 to d16bc37 Compare January 29, 2026 12:29
@sowjanyakch sowjanyakch marked this pull request as ready for review January 29, 2026 12:35
@sowjanyakch sowjanyakch requested a review from mahibi January 29, 2026 12:35
@sowjanyakch sowjanyakch self-assigned this Jan 29, 2026
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Jan 29, 2026
@sowjanyakch sowjanyakch changed the title Improvise scheduled messages UI Improvise scheduled messages UI and solve edit bug Jan 29, 2026
@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings99104
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

Lint increased!

@mahibi
Copy link
Collaborator

mahibi commented Jan 29, 2026

There is a bug with rescheduling/editing scheduled thread replies.

Can you describe this in more detail? What was the problem and what is fixed by the PR?

Removed native android emoji library as it does not have inbuilt search and delete emoji options. I used vanniktech library for this PR and this will be improved in future.

I suggest to use the android emoji library as this should be the default in the future in my opinion. Also if there is no search.

@sowjanyakch
Copy link
Contributor Author

sowjanyakch commented Jan 29, 2026

Can you describe this in more detail? What was the problem and what is fixed by the PR?

STR:

  1. Create a thread.
  2. Schedule a reply to the thread by long press on the send button. You can also schedule a reply to the existing thread.
  3. Try to edit/reschedule the scheduled thread reply. There is an error in both the cases.
Screenshot 2026-01-29 at 18 11 55

The PR will fix this issue.

You can also schedule a reply to a message. Also can edit, delete and reschedule them.

Screenshot 2026-01-29 at 18 20 14

All the cases are fully supported: scheduled messages - reply to a thread, reply to a message, normal text message.

Screenshot 2026-01-29 at 18 25 02

I suggest to use the android emoji library as this should be the default in the future in my opinion. Also if there is no search.

I will take a look again into it and see how we can improve this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI improvements to scheduled messages

3 participants