fix(fonts): copy fonts into the correct place#1245
Open
Goldfels wants to merge 1 commit into
Open
Conversation
Kinda fixes nextcloud#1215 Signed-off-by: Goldfels <Goldfels@users.noreply.github.com>
Goldfels
requested review from
grnd-alt,
hweihwang and
juliusknorr
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the plugin
vite-plugin-static-copystarting from version 4, there's a major breaking change: the folder structure is now always preserved. Because of this, when copying the fonts intodist, it is undernode_modules/...instead offonts, which breaks font loading from the server.This can be easily fixed with the new
renameoption.Technically, this also fixes #1215, since loading fonts from the server is allowed by the CSP.