fix: correct process error handling and git security issues#428
Closed
ivan-aksamentov wants to merge 6 commits intomasterfrom
Closed
fix: correct process error handling and git security issues#428ivan-aksamentov wants to merge 6 commits intomasterfrom
ivan-aksamentov wants to merge 6 commits intomasterfrom
Conversation
- Remove `or res.stderr` condition that treated any stderr output as error - Fix unbound `message` variable in `error_if_empty` path
- `prepare_paths_args`, `git_get_dirty_files`, `git_dir_is_clean` now default to `None` and resolve `getcwd()` at call time - `git_get_modified_files` now defaults to `None` and resolves git hashes at call time - Prevents git commands and filesystem calls from running at module import time
- Replace manual quoting with shlex.quote() in git_commit and github_create_release - Prevents shell injection through commit messages, version strings, repo names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bugs and security issues in the Python build scripts: process error detection no longer treats stderr output as failure, git helper functions no longer execute commands at import time, shell-interpolated values use shlex.quote() to prevent injection, a leaked file handle uses a context manager, and broken string utility functions are removed.