Skip to content

feat: add test_default snapshot#1042

Merged
dialvarezs merged 9 commits into
nf-core:devfrom
dialvarezs:feat/default-snapshot
Jun 30, 2026
Merged

feat: add test_default snapshot#1042
dialvarezs merged 9 commits into
nf-core:devfrom
dialvarezs:feat/default-snapshot

Conversation

@dialvarezs

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@dialvarezs dialvarezs mentioned this pull request May 27, 2026
11 tasks

@jfy133 jfy133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing I noticed, otherwise same suggestion as in other PR about for non-md5sum checks include the file name in the string as well

Comment thread tests/default.nf.test.snap Outdated
@dialvarezs

Copy link
Copy Markdown
Member Author

Hey @jfy133!
I addressed your comment and also applied the same improvements I did in the hybrid snapshot.
Let me know if you find something else.

Comment thread tests/default.nf.test.snap Outdated
@dialvarezs
dialvarezs merged commit 4de8e20 into nf-core:dev Jun 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants