Conversation
This adds the Yleaf package (https://doi.org/10.1093/molbev/msy032) at 3.3.0. Currently locked to the local version while necessary Yleaf update is pending.
jfy133
left a comment
jfy133
left a comment
There was a problem hiding this comment.
Looking good, some initial comments until bioconda recipe is ready
| def args = task.ext.args ?: '' | ||
| def prefix = task.ext.prefix ?: "${meta.id}" | ||
| def ref_genome = reference_genome ?: "hg38" | ||
| // These defaults correspond to the defaults used in the Yleaf package |
There was a problem hiding this comment.
Small comment: if the tool itself has it's own defaults then you don't need to define all of these. Input vals should ONLY be for mandatory inputs where there is no default 1
Footnotes
| { assert process.out.versions != null }, | ||
| { assert process.out.haplogroup != null }, | ||
| { assert process.out.tree != null }, | ||
| { assert process.out.log != null } |
There was a problem hiding this comment.
Is this checking that teh file exists because they are variable? If so we have other patterns for this: https://nf-co.re/docs/contributing/nf-test/assertions
There was a problem hiding this comment.
In fact you don't need the != bit at all
| then { | ||
| assertAll( | ||
| { assert process.success }, | ||
| { assert process.out.versions != null }, |
There was a problem hiding this comment.
| { assert process.out.versions != null }, | |
| { assert process.out.versions }, |
Also all of these can go into a snapshot() function, so they are more explicitly recorded - see other modules for examples
3 participants
This adds the Yleaf package (https://doi.org/10.1093/molbev/msy032) at
3.3.0. Currently locked to the local version while necessary Yleaf
update is pending (genid/Yleaf#32)
Closes #8211.
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda